From dae21ccc7c6cdadb4b37f83378990b51763a1f71 Mon Sep 17 00:00:00 2001 From: sadeghbarati Date: Mon, 8 Jan 2024 11:36:44 +0330 Subject: [PATCH] refactor: fix embla-carousel types after v8.0.0-rc18 update embla deps --- apps/www/package.json | 4 +-- .../lib/registry/default/ui/carousel/index.ts | 6 ++-- .../registry/default/ui/carousel/interface.ts | 6 ++-- .../default/ui/carousel/useCarousel.ts | 7 ++-- .../registry/new-york/ui/carousel/index.ts | 6 ++-- .../new-york/ui/carousel/interface.ts | 6 ++-- .../new-york/ui/carousel/useCarousel.ts | 7 ++-- pnpm-lock.yaml | 34 ++++++++----------- 8 files changed, 37 insertions(+), 39 deletions(-) diff --git a/apps/www/package.json b/apps/www/package.json index 4ee577a4..2ca7ce7c 100644 --- a/apps/www/package.json +++ b/apps/www/package.json @@ -29,8 +29,8 @@ "codesandbox": "^2.2.3", "date-fns": "^2.30.0", "embla-carousel": "8.0.0-rc19", - "embla-carousel-autoplay": "8.0.0-rc18", - "embla-carousel-vue": "8.0.0-rc18", + "embla-carousel-autoplay": "8.0.0-rc19", + "embla-carousel-vue": "8.0.0-rc19", "lucide-vue-next": "^0.276.0", "radix-vue": "^1.2.5", "tailwindcss-animate": "^1.0.7", diff --git a/apps/www/src/lib/registry/default/ui/carousel/index.ts b/apps/www/src/lib/registry/default/ui/carousel/index.ts index 339a2e6e..addfe036 100644 --- a/apps/www/src/lib/registry/default/ui/carousel/index.ts +++ b/apps/www/src/lib/registry/default/ui/carousel/index.ts @@ -5,6 +5,6 @@ export { default as CarouselPrevious } from './CarouselPrevious.vue' export { default as CarouselNext } from './CarouselNext.vue' export { useCarousel } from './useCarousel' -export { - type EmblaCarouselType as CarouselApi, -} from 'embla-carousel-vue' +export type { + EmblaCarouselType as CarouselApi, +} from 'embla-carousel' diff --git a/apps/www/src/lib/registry/default/ui/carousel/interface.ts b/apps/www/src/lib/registry/default/ui/carousel/interface.ts index 68521ddb..99c4f1a8 100644 --- a/apps/www/src/lib/registry/default/ui/carousel/interface.ts +++ b/apps/www/src/lib/registry/default/ui/carousel/interface.ts @@ -3,11 +3,11 @@ import type { EmblaOptionsType as CarouselOptions, EmblaPluginType as CarouselPlugin, } from 'embla-carousel' -import type { HTMLAttributes } from 'vue' +import type { HTMLAttributes, Ref } from 'vue' export interface CarouselProps { - opts?: CarouselOptions - plugins?: CarouselPlugin[] + opts?: CarouselOptions | Ref + plugins?: CarouselPlugin[] | Ref orientation?: 'horizontal' | 'vertical' } diff --git a/apps/www/src/lib/registry/default/ui/carousel/useCarousel.ts b/apps/www/src/lib/registry/default/ui/carousel/useCarousel.ts index 643a9fd7..85a97ebc 100644 --- a/apps/www/src/lib/registry/default/ui/carousel/useCarousel.ts +++ b/apps/www/src/lib/registry/default/ui/carousel/useCarousel.ts @@ -1,8 +1,9 @@ import { createInjectionState } from '@vueuse/core' -import emblaCarouselVue, { - type EmblaCarouselType as CarouselApi, -} from 'embla-carousel-vue' +import emblaCarouselVue from 'embla-carousel-vue' import { onMounted, ref } from 'vue' +import type { + EmblaCarouselType as CarouselApi, +} from 'embla-carousel' import type { CarouselEmits, CarouselProps } from './interface' const [useProvideCarousel, useInjectCarousel] = createInjectionState( diff --git a/apps/www/src/lib/registry/new-york/ui/carousel/index.ts b/apps/www/src/lib/registry/new-york/ui/carousel/index.ts index 339a2e6e..addfe036 100644 --- a/apps/www/src/lib/registry/new-york/ui/carousel/index.ts +++ b/apps/www/src/lib/registry/new-york/ui/carousel/index.ts @@ -5,6 +5,6 @@ export { default as CarouselPrevious } from './CarouselPrevious.vue' export { default as CarouselNext } from './CarouselNext.vue' export { useCarousel } from './useCarousel' -export { - type EmblaCarouselType as CarouselApi, -} from 'embla-carousel-vue' +export type { + EmblaCarouselType as CarouselApi, +} from 'embla-carousel' diff --git a/apps/www/src/lib/registry/new-york/ui/carousel/interface.ts b/apps/www/src/lib/registry/new-york/ui/carousel/interface.ts index 68521ddb..99c4f1a8 100644 --- a/apps/www/src/lib/registry/new-york/ui/carousel/interface.ts +++ b/apps/www/src/lib/registry/new-york/ui/carousel/interface.ts @@ -3,11 +3,11 @@ import type { EmblaOptionsType as CarouselOptions, EmblaPluginType as CarouselPlugin, } from 'embla-carousel' -import type { HTMLAttributes } from 'vue' +import type { HTMLAttributes, Ref } from 'vue' export interface CarouselProps { - opts?: CarouselOptions - plugins?: CarouselPlugin[] + opts?: CarouselOptions | Ref + plugins?: CarouselPlugin[] | Ref orientation?: 'horizontal' | 'vertical' } diff --git a/apps/www/src/lib/registry/new-york/ui/carousel/useCarousel.ts b/apps/www/src/lib/registry/new-york/ui/carousel/useCarousel.ts index 643a9fd7..85a97ebc 100644 --- a/apps/www/src/lib/registry/new-york/ui/carousel/useCarousel.ts +++ b/apps/www/src/lib/registry/new-york/ui/carousel/useCarousel.ts @@ -1,8 +1,9 @@ import { createInjectionState } from '@vueuse/core' -import emblaCarouselVue, { - type EmblaCarouselType as CarouselApi, -} from 'embla-carousel-vue' +import emblaCarouselVue from 'embla-carousel-vue' import { onMounted, ref } from 'vue' +import type { + EmblaCarouselType as CarouselApi, +} from 'embla-carousel' import type { CarouselEmits, CarouselProps } from './interface' const [useProvideCarousel, useInjectCarousel] = createInjectionState( diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 090e38b3..ae7cb36a 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -87,11 +87,11 @@ importers: specifier: 8.0.0-rc19 version: 8.0.0-rc19 embla-carousel-autoplay: - specifier: 8.0.0-rc18 - version: 8.0.0-rc18(embla-carousel@8.0.0-rc19) + specifier: 8.0.0-rc19 + version: 8.0.0-rc19(embla-carousel@8.0.0-rc19) embla-carousel-vue: - specifier: 8.0.0-rc18 - version: 8.0.0-rc18(vue@3.3.7) + specifier: 8.0.0-rc19 + version: 8.0.0-rc19(vue@3.3.7) lucide-vue-next: specifier: ^0.276.0 version: 0.276.0(vue@3.3.7) @@ -7090,36 +7090,32 @@ packages: resolution: {integrity: sha512-L6uRgvZTH+4OF5NE/MBbzQx/WYpru1xCBE9respNj6qznEewGUIfhzmm7horWWxbNO2M0WckQypGctR8lH79xQ==} dev: false - /embla-carousel-autoplay@8.0.0-rc18(embla-carousel@8.0.0-rc19): - resolution: {integrity: sha512-4TgnvSRlAz6YxyUIOU7w9wkUbqq/iVoJdRIRZ0+QQSWl+giout8HB0/HDqDPKJy23zjtpDNnYdNn3dxdKfGFfQ==} + /embla-carousel-autoplay@8.0.0-rc19(embla-carousel@8.0.0-rc19): + resolution: {integrity: sha512-c1pxsGHuWbYD3outH5y4L+kzg15smyHKFIDmXLaXlI6rCiizzf6hWMW0ZgxJLV4y4nUwDrYhM6TtzxvvOcsfUw==} peerDependencies: - embla-carousel: 8.0.0-rc18 + embla-carousel: 8.0.0-rc19 dependencies: embla-carousel: 8.0.0-rc19 dev: false - /embla-carousel-reactive-utils@8.0.0-rc18(embla-carousel@8.0.0-rc18): - resolution: {integrity: sha512-VOFfvhkICz4GKXb/huMTspYVR8mx8C4uDf0Kp+jA9iZNUA4lmlfxxYUr++SwIy1xABycpqML/9hP2tV6Nn0AEQ==} + /embla-carousel-reactive-utils@8.0.0-rc19(embla-carousel@8.0.0-rc19): + resolution: {integrity: sha512-ed9NppY0OxTtrSIwTCYNcMLlQfSNcNy8Zsw8uIG0te3qrhvQ2ePPsbcElK2SRAV8VMU6G7JQweQIb6amzYMDXA==} peerDependencies: - embla-carousel: 8.0.0-rc18 + embla-carousel: 8.0.0-rc19 dependencies: - embla-carousel: 8.0.0-rc18 + embla-carousel: 8.0.0-rc19 dev: false - /embla-carousel-vue@8.0.0-rc18(vue@3.3.7): - resolution: {integrity: sha512-wbQyx/QuyDFoB0FzWLr5NQmgiwUDhUFHvLILSrZE+rbIKqHCDjHC2vCKZzlWezJqcDDTHWAzDaO1yWMZnUEOkQ==} + /embla-carousel-vue@8.0.0-rc19(vue@3.3.7): + resolution: {integrity: sha512-dqkmatB7/WNXHEwFGtQNpYT8TWnE6KRcVBfnPTswBba8I33RdBRuj0CqRHem02dlIS1ySgS9sBVVdDXe+6IGKQ==} peerDependencies: vue: ^3.2.37 dependencies: - embla-carousel: 8.0.0-rc18 - embla-carousel-reactive-utils: 8.0.0-rc18(embla-carousel@8.0.0-rc18) + embla-carousel: 8.0.0-rc19 + embla-carousel-reactive-utils: 8.0.0-rc19(embla-carousel@8.0.0-rc19) vue: 3.3.7(typescript@5.2.2) dev: false - /embla-carousel@8.0.0-rc18: - resolution: {integrity: sha512-MtiatQCt+R/lEKl2D4TyAx2Ba4/gfosQIY+Y/ooZu1yahxTbFLyhGW8aodn0GW2WZ6jO3Qpfx7VuqCPdRV5moQ==} - dev: false - /embla-carousel@8.0.0-rc19: resolution: {integrity: sha512-PAChVyYoVZo8subkBN8LjZ7+0vk4CmVvMnxH0Y2ux76VUEUBl1wk5xDo8+MUhH5MXU6ZrgkBpMe++bKob1Z+2g==} dev: false