From 8c143aed9940f586c6826bfefeecbecaffc2cf9b Mon Sep 17 00:00:00 2001
From: Shl <kitkitcot@yandex.ru>
Date: Mon, 8 Jul 2024 17:40:02 +0700
Subject: [PATCH] fix: passing the generic type that is expected in command.vue

---
 .../components/DataTableFacetedFilter.vue      | 18 +-----------------
 .../registry/new-york/ui/command/Command.vue   |  5 ++---
 2 files changed, 3 insertions(+), 20 deletions(-)

diff --git a/apps/www/src/examples/tasks/components/DataTableFacetedFilter.vue b/apps/www/src/examples/tasks/components/DataTableFacetedFilter.vue
index 24f8cd4a..be437a90 100644
--- a/apps/www/src/examples/tasks/components/DataTableFacetedFilter.vue
+++ b/apps/www/src/examples/tasks/components/DataTableFacetedFilter.vue
@@ -31,22 +31,6 @@ const props = defineProps<DataTableFacetedFilter>()
 
 const facets = computed(() => props.column?.getFacetedUniqueValues())
 const selectedValues = computed(() => new Set(props.column?.getFilterValue() as string[]))
-
-type ReturnTypeFilterFunction = string[] | number[] | false[] | true[] | Record<string, any>[]
-
-function isListOptions(list: ReturnTypeFilterFunction | DataTableFacetedFilter['options']): list is DataTableFacetedFilter['options'] {
-  return Array.isArray(list) && list.length > 0 && 'value' in (list[0] as DataTableFacetedFilter['options'])
-}
-
-function filterFunction(list: ReturnTypeFilterFunction | DataTableFacetedFilter['options'], term: string): DataTableFacetedFilter['options'] {
-  if (isListOptions(list)) {
-    return list.filter(i => i.label.toLowerCase()?.includes(term))
-  }
-  else {
-    console.error('List is not a DataTableFacetedFilter options')
-    return []
-  }
-}
 </script>
 
 <template>
@@ -89,7 +73,7 @@ function filterFunction(list: ReturnTypeFilterFunction | DataTableFacetedFilter[
     </PopoverTrigger>
     <PopoverContent class="w-[200px] p-0" align="start">
       <Command
-        :filter-function="filterFunction"
+        :filter-function="(list: DataTableFacetedFilter['options'], term) => list.filter(i => i.label.toLowerCase()?.includes(term))"
       >
         <CommandInput :placeholder="title" />
         <CommandList>
diff --git a/apps/www/src/lib/registry/new-york/ui/command/Command.vue b/apps/www/src/lib/registry/new-york/ui/command/Command.vue
index fe7445c0..e6f8f72e 100644
--- a/apps/www/src/lib/registry/new-york/ui/command/Command.vue
+++ b/apps/www/src/lib/registry/new-york/ui/command/Command.vue
@@ -1,12 +1,11 @@
-<script setup lang="ts">
+<script setup lang="ts" generic="T extends string | number | boolean | Record<string, any>">
 import { type HTMLAttributes, computed } from 'vue'
 import type { ComboboxRootEmits, ComboboxRootProps } from 'radix-vue'
 import { ComboboxRoot, useForwardPropsEmits } from 'radix-vue'
 import { cn } from '@/lib/utils'
 
-const props = withDefaults(defineProps<ComboboxRootProps & { class?: HTMLAttributes['class'] }>(), {
+const props = withDefaults(defineProps<ComboboxRootProps<T> & { class?: HTMLAttributes['class'] }>(), {
   open: true,
-  modelValue: '',
 })
 
 const emits = defineEmits<ComboboxRootEmits>()